Waypoint: Remove module version #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
remove-module-version
branch
from
15c673e to
d043aa3
Compare
paladin-devops
force-pushed
the
add-on-input-vars
branch
from
3b940d6 to
74089bb
Compare
paladin-devops
force-pushed
the
remove-module-version
branch
from
d043aa3 to
464f8e5
Compare
paladin-devops
force-pushed
the
remove-module-version
branch
from
79a3212 to
46546ef
Compare
catsby
approved these changes
Jul 30, 2024
HenryEstberg
reviewed
Aug 6, 2024
There was a problem hiding this comment.
This all looks good, like you mentioned in your corresponding Waypoint PR this will ofc need to wait until that is merged and the SDK is updated as well. Because that SDK update will likely have to be included here, I will hold off on approving officially until then.
HenryEstberg
approved these changes
Aug 8, 2024
jasonpilz
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of a no-code module is being removed from Waypoint templates and add-ons. The pinned version for a no-code module in HCP TF will be used at provision time.